Xargon/Duckstation
1
0
Fork 0
mirror of https://github.com/RetroDECK/Duckstation.git synced 2024-11-25 23:25:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

CDImageCHD: Refactor mode conversion to string_view

Browse source 
Incorrect length found by PVS-Studio.
This commit is contained in:
Stenzek 2024-07-14 21:29:55 +10:00
parent 640ed4a2d3
commit 154a5b35b8
No known key found for this signature in database
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/util/cd_image_chd.cpp
View file

@ -31,23 +31,23 @@ Log_SetChannel(CDImageCHD);
namespace {
static std::optional<CDImage::TrackMode> ParseTrackModeString(const char* str)
static std::optional<CDImage::TrackMode> ParseTrackModeString(const std::string_view str)
{
if (std::strncmp(str, "MODE2_FORM_MIX", 14) == 0)
if (str == "MODE2_FORM_MIX")
return CDImage::TrackMode::Mode2FormMix;
else if (std::strncmp(str, "MODE2_FORM1", 10) == 0)
else if (str == "MODE2_FORM1")
return CDImage::TrackMode::Mode2Form1;
else if (std::strncmp(str, "MODE2_FORM2", 10) == 0)
else if (str == "MODE2_FORM2")
return CDImage::TrackMode::Mode2Form2;
else if (std::strncmp(str, "MODE2_RAW", 9) == 0)
else if (str == "MODE2_RAW")
return CDImage::TrackMode::Mode2Raw;
else if (std::strncmp(str, "MODE1_RAW", 9) == 0)
else if (str == "MODE1_RAW")
return CDImage::TrackMode::Mode1Raw;
else if (std::strncmp(str, "MODE1", 5) == 0)
else if (str == "MODE1")
return CDImage::TrackMode::Mode1;
else if (std::strncmp(str, "MODE2", 5) == 0)
else if (str == "MODE2")
return CDImage::TrackMode::Mode2;
else if (std::strncmp(str, "AUDIO", 5) == 0)
else if (str == "AUDIO")
return CDImage::TrackMode::Audio;
else
return std::nullopt;