From 2a1bf9925a933c781f8fa4e7e88a35ccbb0bdb60 Mon Sep 17 00:00:00 2001 From: Albert Liu <45282415+ggrtk@users.noreply.github.com> Date: Sat, 26 Dec 2020 23:35:48 -0800 Subject: [PATCH] Qt: Make Auto (Game Native) aspect ratio string translatable --- src/core/settings.cpp | 6 +++--- src/duckstation-qt/displaysettingswidget.cpp | 2 +- src/duckstation-qt/gamepropertiesdialog.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/core/settings.cpp b/src/core/settings.cpp index a73ea9246..211a8a717 100644 --- a/src/core/settings.cpp +++ b/src/core/settings.cpp @@ -655,9 +655,9 @@ const char* Settings::GetDisplayCropModeDisplayName(DisplayCropMode crop_mode) return s_display_crop_mode_display_names[static_cast(crop_mode)]; } -static std::array s_display_aspect_ratio_names = {{"Auto (Game Native)", "4:3", "16:9", "16:10", - "19:9", "21:9", "32:9", "8:7", "5:4", "3:2", - "2:1 (VRAM 1:1)", "1:1", "PAR 1:1"}}; +static std::array s_display_aspect_ratio_names = { + {TRANSLATABLE("DisplayAspectRatio", "Auto (Game Native)"), "4:3", "16:9", "16:10", "19:9", "21:9", "32:9", "8:7", + "5:4", "3:2", "2:1 (VRAM 1:1)", "1:1", "PAR 1:1"}}; static constexpr std::array s_display_aspect_ratio_values = { {-1.0f, 4.0f / 3.0f, 16.0f / 9.0f, 16.0f / 10.0f, 19.0f / 9.0f, 64.0f / 27.0f, 32.0f / 9.0f, 8.0f / 7.0f, 5.0f / 4.0f, 3.0f / 2.0f, 2.0f / 1.0f, 1.0f, -1.0f}}; diff --git a/src/duckstation-qt/displaysettingswidget.cpp b/src/duckstation-qt/displaysettingswidget.cpp index d4d007436..63f2caeb6 100644 --- a/src/duckstation-qt/displaysettingswidget.cpp +++ b/src/duckstation-qt/displaysettingswidget.cpp @@ -131,7 +131,7 @@ void DisplaySettingsWidget::setupAdditionalUi() for (u32 i = 0; i < static_cast(DisplayAspectRatio::Count); i++) { m_ui.displayAspectRatio->addItem( - QString::fromUtf8(Settings::GetDisplayAspectRatioName(static_cast(i)))); + qApp->translate("DisplayAspectRatio", Settings::GetDisplayAspectRatioName(static_cast(i)))); } for (u32 i = 0; i < static_cast(DisplayCropMode::Count); i++) diff --git a/src/duckstation-qt/gamepropertiesdialog.cpp b/src/duckstation-qt/gamepropertiesdialog.cpp index 6e87ce02e..c41946b54 100644 --- a/src/duckstation-qt/gamepropertiesdialog.cpp +++ b/src/duckstation-qt/gamepropertiesdialog.cpp @@ -122,7 +122,7 @@ void GamePropertiesDialog::setupAdditionalUi() for (u32 i = 0; i < static_cast(DisplayAspectRatio::Count); i++) { m_ui.userAspectRatio->addItem( - QString::fromUtf8(Settings::GetDisplayAspectRatioName(static_cast(i)))); + qApp->translate("DisplayAspectRatio", Settings::GetDisplayAspectRatioName(static_cast(i)))); } m_ui.userCropMode->addItem(tr("(unchanged)"));