Xargon/Duckstation
1
0
Fork 0
mirror of https://github.com/RetroDECK/Duckstation.git synced 2025-03-06 14:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Common/BitField: Fix off-by-one error for signed types

Browse source 
Fixes Darkstalkers 3 character select screen.
This commit is contained in:
Connor McLaughlin 2020-04-27 00:13:23 +10:00
parent dc1e1b5adf
commit 341b163ca1
1 changed files with 2 additions and 2 deletions

4
src/common/bitfield.h
View file

@ -119,8 +119,8 @@ struct BitField
} }
else if constexpr (std::is_signed_v<DataType>) else if constexpr (std::is_signed_v<DataType>)
{ {
constexpr int shift = 8 * sizeof(DataType) - BitCount; constexpr int shift = 8 * sizeof(DataType) - BitCount + 1;
return (static_cast<DataType>((data & GetMask()) >> BitIndex) << shift) >> shift; return (static_cast<DataType>(data >> BitIndex) << shift) >> shift;
} }
else else
{ {