From 4e8da3cb417ad54d211327cfe0cde450bead45d4 Mon Sep 17 00:00:00 2001 From: Connor McLaughlin Date: Thu, 28 May 2020 03:07:32 +1000 Subject: [PATCH] CDROM: Replace sound map assert with error log I am not aware of any games which use it yet, so have no way of testing if the implementation is correct. --- src/core/cdrom.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/core/cdrom.cpp b/src/core/cdrom.cpp index 807ef52b0..b164158ad 100644 --- a/src/core/cdrom.cpp +++ b/src/core/cdrom.cpp @@ -325,10 +325,15 @@ void CDROM::WriteRegister(u32 offset, u8 value) case 2: { - // TODO: sector buffer is not the data fifo Log_DebugPrintf("Request register <- 0x%02X", value); const RequestRegister rr{value}; - Assert(!rr.SMEN); + + // Sound map is not currently implemented, haven't found anything which uses it. + if (rr.SMEN) + Log_ErrorPrintf("Sound map enable set"); + if (rr.BFWR) + Log_ErrorPrintf("Buffer write enable set"); + if (rr.BFRD) { LoadDataFIFO();