From 72e62911073a3db33c8c85b236b83f050fd4e65a Mon Sep 17 00:00:00 2001 From: Connor McLaughlin Date: Sun, 4 Apr 2021 13:30:11 +1000 Subject: [PATCH] HTTPDownloader: Drop user agent from base class --- src/frontend-common/http_downloader.h | 1 - src/frontend-common/http_downloader_winhttp.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/frontend-common/http_downloader.h b/src/frontend-common/http_downloader.h index 192d9d720..2b9e8f82c 100644 --- a/src/frontend-common/http_downloader.h +++ b/src/frontend-common/http_downloader.h @@ -75,7 +75,6 @@ protected: u32 LockedGetActiveRequestCount(); void LockedPollRequests(std::unique_lock& lock); - std::string m_user_agent; float m_timeout; u32 m_max_active_requests; diff --git a/src/frontend-common/http_downloader_winhttp.cpp b/src/frontend-common/http_downloader_winhttp.cpp index 9ac001ae0..15d19f50f 100644 --- a/src/frontend-common/http_downloader_winhttp.cpp +++ b/src/frontend-common/http_downloader_winhttp.cpp @@ -37,7 +37,7 @@ bool HTTPDownloaderWinHttp::Initialize(const char* user_agent) const DWORD dwAccessType = IsWindows8Point1OrGreater() ? WINHTTP_ACCESS_TYPE_AUTOMATIC_PROXY : WINHTTP_ACCESS_TYPE_DEFAULT_PROXY; - m_hSession = WinHttpOpen(StringUtil::UTF8StringToWideString(m_user_agent).c_str(), dwAccessType, nullptr, nullptr, + m_hSession = WinHttpOpen(StringUtil::UTF8StringToWideString(user_agent).c_str(), dwAccessType, nullptr, nullptr, WINHTTP_FLAG_ASYNC); if (m_hSession == NULL) {