From 7b87b386a9ee7b3c525f56553ef9ac8afade8b24 Mon Sep 17 00:00:00 2001 From: Connor McLaughlin Date: Mon, 21 Jun 2021 22:04:38 +1000 Subject: [PATCH] CPU/Recompiler: Fix performance regression in AArch32/64 --- src/core/cpu_recompiler_code_generator_aarch32.cpp | 2 -- src/core/cpu_recompiler_code_generator_aarch64.cpp | 2 -- src/core/cpu_recompiler_code_generator_generic.cpp | 4 ++-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/core/cpu_recompiler_code_generator_aarch32.cpp b/src/core/cpu_recompiler_code_generator_aarch32.cpp index 397a75263..260ee8a74 100644 --- a/src/core/cpu_recompiler_code_generator_aarch32.cpp +++ b/src/core/cpu_recompiler_code_generator_aarch32.cpp @@ -1469,8 +1469,6 @@ void CodeGenerator::EmitStoreGuestMemoryFastmem(const CodeBlockInstruction& cbi, void CodeGenerator::EmitStoreGuestMemorySlowmem(const CodeBlockInstruction& cbi, const Value& address, RegSize size, const Value& value, bool in_far_code) { - AddPendingCycles(true); - Value value_in_hr = GetValueInHostRegister(value); if (g_settings.cpu_recompiler_memory_exceptions) diff --git a/src/core/cpu_recompiler_code_generator_aarch64.cpp b/src/core/cpu_recompiler_code_generator_aarch64.cpp index 178b629cf..5d57aa56e 100644 --- a/src/core/cpu_recompiler_code_generator_aarch64.cpp +++ b/src/core/cpu_recompiler_code_generator_aarch64.cpp @@ -1665,8 +1665,6 @@ void CodeGenerator::EmitStoreGuestMemoryFastmem(const CodeBlockInstruction& cbi, void CodeGenerator::EmitStoreGuestMemorySlowmem(const CodeBlockInstruction& cbi, const Value& address, RegSize size, const Value& value, bool in_far_code) { - AddPendingCycles(true); - Value value_in_hr = GetValueInHostRegister(value); if (g_settings.cpu_recompiler_memory_exceptions) diff --git a/src/core/cpu_recompiler_code_generator_generic.cpp b/src/core/cpu_recompiler_code_generator_generic.cpp index 2585f1f29..2a14b6e5f 100644 --- a/src/core/cpu_recompiler_code_generator_generic.cpp +++ b/src/core/cpu_recompiler_code_generator_generic.cpp @@ -44,8 +44,8 @@ Value CodeGenerator::EmitLoadGuestMemory(const CodeBlockInstruction& cbi, const if (g_settings.IsUsingFastmem() && Bus::IsRAMAddress(static_cast(address.constant_value))) { // have to mask away the high bits for mirrors, since we don't map them in fastmem - EmitLoadGuestRAMFastmem(Value::FromConstantU32(static_cast(address.constant_value) & Bus::g_ram_mask), size, - result); + EmitLoadGuestRAMFastmem(Value::FromConstantU32(static_cast(address.constant_value) & Bus::g_ram_mask), + size, result); } else {