From 98b4101cd7e936f58fbd3efda8837c2643fb0639 Mon Sep 17 00:00:00 2001 From: Connor McLaughlin Date: Sat, 30 Jan 2021 15:30:33 +1000 Subject: [PATCH] Settings: Expose Save() method to interface --- android/app/src/cpp/android_settings_interface.cpp | 5 +++++ android/app/src/cpp/android_settings_interface.h | 1 + src/core/settings.h | 1 + src/frontend-common/ini_settings_interface.h | 2 +- 4 files changed, 8 insertions(+), 1 deletion(-) diff --git a/android/app/src/cpp/android_settings_interface.cpp b/android/app/src/cpp/android_settings_interface.cpp index 79c975448..0cfcf1f53 100644 --- a/android/app/src/cpp/android_settings_interface.cpp +++ b/android/app/src/cpp/android_settings_interface.cpp @@ -83,6 +83,11 @@ AndroidSettingsInterface::~AndroidSettingsInterface() env->DeleteGlobalRef(m_helper_class); } +bool AndroidSettingsInterface::Save() +{ + return true; +} + void AndroidSettingsInterface::Clear() { Log_ErrorPrint("Not implemented"); diff --git a/android/app/src/cpp/android_settings_interface.h b/android/app/src/cpp/android_settings_interface.h index b4550ddcf..542a2f90e 100644 --- a/android/app/src/cpp/android_settings_interface.h +++ b/android/app/src/cpp/android_settings_interface.h @@ -8,6 +8,7 @@ public: AndroidSettingsInterface(jobject java_context); ~AndroidSettingsInterface(); + bool Save() override; void Clear() override; int GetIntValue(const char* section, const char* key, int default_value = 0) override; diff --git a/src/core/settings.h b/src/core/settings.h index f8d49d02d..be049fddc 100644 --- a/src/core/settings.h +++ b/src/core/settings.h @@ -11,6 +11,7 @@ class SettingsInterface public: virtual ~SettingsInterface(); + virtual bool Save() = 0; virtual void Clear() = 0; virtual int GetIntValue(const char* section, const char* key, int default_value = 0) = 0; diff --git a/src/frontend-common/ini_settings_interface.h b/src/frontend-common/ini_settings_interface.h index a75c4c21c..a4b934201 100644 --- a/src/frontend-common/ini_settings_interface.h +++ b/src/frontend-common/ini_settings_interface.h @@ -13,7 +13,7 @@ public: INISettingsInterface(std::string filename); ~INISettingsInterface() override; - bool Save(); + bool Save() override; void Clear() override;