Xargon/Duckstation
1
0
Fork 0
mirror of https://github.com/RetroDECK/Duckstation.git synced 2025-01-18 22:35:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Android: Prevent OOM when importing invalid BIOSes

Browse source
This commit is contained in:
Connor McLaughlin 2020-10-14 18:58:42 +10:00
parent 19f4921ca7
commit e5cdb7751b
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
android/app/src/main/java/com/github/stenzek/duckstation/MainActivity.java
View file

@ -292,6 +292,9 @@ public class MainActivity extends AppCompatActivity {
}
private void onImportBIOSImageResult(Uri uri) {
// This should really be 512K but just in case we wanted to support the other BIOSes in the future...
final int MAX_BIOS_SIZE = 2 * 1024 * 1024;
InputStream stream = null;
try {
stream = getContentResolver().openInputStream(uri);
@ -304,10 +307,14 @@ public class MainActivity extends AppCompatActivity {
try {
byte[] buffer = new byte[512 * 1024];
int len;
while ((len = stream.read(buffer)) > 0)
while ((len = stream.read(buffer)) > 0) {
os.write(buffer, 0, len);
if (os.size() > MAX_BIOS_SIZE) {
throw new IOException("BIOS image is too large.");
}
}
} catch (IOException e) {
Toast.makeText(this, "Failed to read BIOS image.", Toast.LENGTH_LONG);
Toast.makeText(this, "Failed to read BIOS image: " + e.getMessage(), Toast.LENGTH_LONG);
return;
}