From ed4ed259e3d5d08ee69ab6a9e60787bb21d4ba5b Mon Sep 17 00:00:00 2001
From: Max833 <53529402+Max833@users.noreply.github.com>
Date: Thu, 28 Jan 2021 12:03:51 +0100
Subject: [PATCH] UI: Add missing register widget help (#1515)
* Update displaysettingswidget.cpp
* Update generalsettingswidget.cpp
* Update consolesettingswidget.cpp
---
src/duckstation-qt/consolesettingswidget.cpp | 24 +++++++++++++++++---
src/duckstation-qt/displaysettingswidget.cpp | 4 +++-
src/duckstation-qt/generalsettingswidget.cpp | 2 ++
3 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/src/duckstation-qt/consolesettingswidget.cpp b/src/duckstation-qt/consolesettingswidget.cpp
index 6163ab4a9..219ab041e 100644
--- a/src/duckstation-qt/consolesettingswidget.cpp
+++ b/src/duckstation-qt/consolesettingswidget.cpp
@@ -36,13 +36,31 @@ ConsoleSettingsWidget::ConsoleSettingsWidget(QtHostInterface* host_interface, QW
false);
dialog->registerWidgetHelp(
- m_ui.cdromLoadImageToRAM, tr("Preload Image to RAM"), tr("Unchecked"),
- tr("Loads the game image into RAM. Useful for network paths that may become unreliable during gameplay. In some "
- "cases also eliminates stutter when games initiate audio track playback."));
+ m_ui.region, tr("Region"), tr("Auto-Detect"),
+ tr("Determines the emulated hardware type."));
+ dialog->registerWidgetHelp(
+ m_ui.cpuExecutionMode, tr("Execution Mode"), tr("Recompiler (Fastest)"),
+ tr("Determines how the emulated CPU executes instructions."));
+ dialog->registerWidgetHelp(
+ m_ui.enableCPUClockSpeedControl, tr("Enable Clock Speed Control (Overclocking/Underclocking)"), tr("Unchecked"),
+ tr("When this option is chosen, the clock speed set below will be used."));
+ dialog->registerWidgetHelp(
+ m_ui.cpuClockSpeed, tr("Overclocking Percentage"), tr("100%"),
+ tr("Selects the percentage of the normal clock speed the emulated hardware will run at."));
dialog->registerWidgetHelp(
m_ui.cdromReadSpeedup, tr("CDROM Read Speedup"), tr("None (Double Speed)"),
tr("Speeds up CD-ROM reads by the specified factor. Only applies to double-speed reads, and is ignored when audio "
"is playing. May improve loading speeds in some games, at the cost of breaking others."));
+ dialog->registerWidgetHelp(
+ m_ui.cdromReadThread, tr("Use Read Thread (Asynchronous)"), tr("Checked"),
+ tr("Reduces hitches in emulation by reading/decompressing CD data asynchronously on a worker thread."));
+ dialog->registerWidgetHelp(
+ m_ui.cdromRegionCheck, tr("Enable Region Check"), tr("Checked"),
+ tr("Simulates the region check present in original, unmodified consoles."));
+ dialog->registerWidgetHelp(
+ m_ui.cdromLoadImageToRAM, tr("Preload Image to RAM"), tr("Unchecked"),
+ tr("Loads the game image into RAM. Useful for network paths that may become unreliable during gameplay. In some "
+ "cases also eliminates stutter when games initiate audio track playback."));
m_ui.cpuClockSpeed->setEnabled(m_ui.enableCPUClockSpeedControl->checkState() == Qt::Checked);
m_ui.cdromReadSpeedup->setCurrentIndex(m_host_interface->GetIntSettingValue("CDROM", "ReadSpeedup", 1) - 1);
diff --git a/src/duckstation-qt/displaysettingswidget.cpp b/src/duckstation-qt/displaysettingswidget.cpp
index 5bdddfb25..f81d92d64 100644
--- a/src/duckstation-qt/displaysettingswidget.cpp
+++ b/src/duckstation-qt/displaysettingswidget.cpp
@@ -113,6 +113,8 @@ DisplaySettingsWidget::DisplaySettingsWidget(QtHostInterface* host_interface, QW
dialog->registerWidgetHelp(
m_ui.showSpeed, tr("Show Speed"), tr("Unchecked"),
tr("Shows the current emulation speed of the system in the top-right corner of the display as a percentage."));
+ dialog->registerWidgetHelp(m_ui.showResolution, tr("Show Resolution"), tr("Unchecked"),
+ tr("Shows the resolution of the game in the top-right corner of the display."));
#ifdef _WIN32
{
@@ -255,4 +257,4 @@ void DisplaySettingsWidget::onGPUFullscreenModeIndexChanged()
m_host_interface->SetStringSettingValue("GPU", "FullscreenMode",
m_ui.fullscreenMode->currentText().toUtf8().constData());
-}
\ No newline at end of file
+}
diff --git a/src/duckstation-qt/generalsettingswidget.cpp b/src/duckstation-qt/generalsettingswidget.cpp
index a9d56c227..3621501c3 100644
--- a/src/duckstation-qt/generalsettingswidget.cpp
+++ b/src/duckstation-qt/generalsettingswidget.cpp
@@ -67,6 +67,8 @@ GeneralSettingsWidget::GeneralSettingsWidget(QtHostInterface* host_interface, QW
m_ui.applyGameSettings, tr("Apply Per-Game Settings"), tr("Checked"),
tr("When enabled, per-game settings will be applied, and incompatible enhancements will be disabled. You should "
"leave this option enabled except when testing enhancements with incompatible games."));
+ dialog->registerWidgetHelp(m_ui.autoLoadCheats, tr("Automatically Load Cheats"), tr("Unchecked"),
+ tr("Automatically loads and applies cheats on game start."));
dialog->registerWidgetHelp(m_ui.controllerBackend, tr("Controller Backend"),
qApp->translate("ControllerInterface", ControllerInterface::GetBackendName(
ControllerInterface::GetDefaultBackend())),