Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-22 06:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed an issue with scraping Nintendo Famicom games.

Browse source 
Also did some other minor platform cleanups.
This commit is contained in:
Leon Styhre 2021-07-17 10:37:36 +02:00
parent 62c5c379fa
commit 00b49b5d1a
7 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -101,6 +101,7 @@ Apart from this, numerous small improvements and bug fixes are part of the relea
* GuiDetectDevice wouldn't detect controller input that was of the "axis" type (i.e. analog inputs) * GuiDetectDevice wouldn't detect controller input that was of the "axis" type (i.e. analog inputs)
* GuiInputConfig didn't correctly inform which buttons could be skipped for some rows * GuiInputConfig didn't correctly inform which buttons could be skipped for some rows
* The scraper would sometimes consider very small images to be invalid * The scraper would sometimes consider very small images to be invalid
* Scraper searches for Nintendo Family Computer (Famicom) games were not accurate
* The Quick System Select help prompt was shown even when there was only a single game system present * The Quick System Select help prompt was shown even when there was only a single game system present
* The "Back (cancel)" help prompt was missing for the single-game scraper * The "Back (cancel)" help prompt was missing for the single-game scraper
* The "Y" button help prompt wasn't displayed correctly when using the Grid view style * The "Y" button help prompt wasn't displayed correctly when using the Grid view style

4
es-app/src/PlatformId.cpp
View file

@ -85,8 +85,8 @@ namespace PlatformIds
"pc", // IBM PC "pc", // IBM PC
"pc88", // NEC PC-8800 series "pc88", // NEC PC-8800 series
"pc98", // NEC PC-9800 series "pc98", // NEC PC-9800 series
"pcengine", // NEC PC Engine "pcengine", // NEC PC Engine / TurboGrafx-16
"pcenginecd", // NEC PC Engine CD "pcenginecd", // NEC PC Engine CD / TurboGrafx-CD
"pcfx", // NEC PC-FX "pcfx", // NEC PC-FX
"pokemini", // Nintendo Pokémon Mini "pokemini", // Nintendo Pokémon Mini
"ps2", // Sony PlayStation 2 "ps2", // Sony PlayStation 2

1
es-app/src/scrapers/GamesDBJSONScraper.cpp
View file

@ -68,6 +68,7 @@ const std::map<PlatformId, std::string> gamesdb_new_platformid_map {
{ NINTENDO_3DS, "4912" }, { NINTENDO_3DS, "4912" },
{ NINTENDO_64, "3" }, { NINTENDO_64, "3" },
{ NINTENDO_DS, "8" }, { NINTENDO_DS, "8" },
{ NINTENDO_FAMICOM, "7" },
{ NINTENDO_FAMICOM_DISK_SYSTEM, "4936" }, { NINTENDO_FAMICOM_DISK_SYSTEM, "4936" },
{ NINTENDO_ENTERTAINMENT_SYSTEM, "7" }, { NINTENDO_ENTERTAINMENT_SYSTEM, "7" },
{ NINTENDO_GAME_BOY, "4" }, { NINTENDO_GAME_BOY, "4" },

1
es-app/src/scrapers/ScreenScraper.cpp
View file

@ -67,6 +67,7 @@ const std::map<PlatformId, unsigned short> screenscraper_platformid_map {
{ NINTENDO_3DS, 17 }, { NINTENDO_3DS, 17 },
{ NINTENDO_64, 14 }, { NINTENDO_64, 14 },
{ NINTENDO_DS, 15 }, { NINTENDO_DS, 15 },
{ NINTENDO_FAMICOM, 3 },
{ NINTENDO_FAMICOM_DISK_SYSTEM, 106 }, { NINTENDO_FAMICOM_DISK_SYSTEM, 106 },
{ NINTENDO_ENTERTAINMENT_SYSTEM, 3 }, { NINTENDO_ENTERTAINMENT_SYSTEM, 3 },
{ FAIRCHILD_CHANNELF, 80 }, { FAIRCHILD_CHANNELF, 80 },

6
resources/systems/macos/es_systems.xml
View file

@ -331,7 +331,7 @@
<path>%ROMPATH%/famicom</path> <path>%ROMPATH%/famicom</path>
<extension>.nes .NES .unf .UNF .unif .UNIF .7z .7Z .zip .ZIP</extension> <extension>.nes .NES .unf .UNF .unif .UNIF .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/nestopia_libretro.dylib %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/nestopia_libretro.dylib %ROM%</command>
<platform>nes, famicom</platform> <platform>famicom</platform>
<theme>famicom</theme> <theme>famicom</theme>
</system> </system>
<system> <system>
@ -421,7 +421,7 @@
<path>%ROMPATH%/genesis</path> <path>%ROMPATH%/genesis</path>
<extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension> <extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.dylib %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.dylib %ROM%</command>
<platform>genesis, megadrive</platform> <platform>genesis</platform>
<theme>genesis</theme> <theme>genesis</theme>
</system> </system>
<system> <system>
@ -538,7 +538,7 @@
<path>%ROMPATH%/megadrive</path> <path>%ROMPATH%/megadrive</path>
<extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension> <extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.dylib %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.dylib %ROM%</command>
<platform>megadrive, genesis</platform> <platform>megadrive</platform>
<theme>megadrive</theme> <theme>megadrive</theme>
</system> </system>
<system> <system>

6
resources/systems/unix/es_systems.xml
View file

@ -331,7 +331,7 @@
<path>%ROMPATH%/famicom</path> <path>%ROMPATH%/famicom</path>
<extension>.nes .NES .unf .UNF .unif .UNIF .7z .7Z .zip .ZIP</extension> <extension>.nes .NES .unf .UNF .unif .UNIF .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/nestopia_libretro.so %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/nestopia_libretro.so %ROM%</command>
<platform>nes, famicom</platform> <platform>famicom</platform>
<theme>famicom</theme> <theme>famicom</theme>
</system> </system>
<system> <system>
@ -421,7 +421,7 @@
<path>%ROMPATH%/genesis</path> <path>%ROMPATH%/genesis</path>
<extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension> <extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.so %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.so %ROM%</command>
<platform>genesis, megadrive</platform> <platform>genesis</platform>
<theme>genesis</theme> <theme>genesis</theme>
</system> </system>
<system> <system>
@ -538,7 +538,7 @@
<path>%ROMPATH%/megadrive</path> <path>%ROMPATH%/megadrive</path>
<extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension> <extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.so %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%/genesis_plus_gx_libretro.so %ROM%</command>
<platform>megadrive, genesis</platform> <platform>megadrive</platform>
<theme>megadrive</theme> <theme>megadrive</theme>
</system> </system>
<system> <system>

6
resources/systems/windows/es_systems.xml
View file

@ -331,7 +331,7 @@
<path>%ROMPATH%\famicom</path> <path>%ROMPATH%\famicom</path>
<extension>.nes .NES .unf .UNF .unif .UNIF .7z .7Z .zip .ZIP</extension> <extension>.nes .NES .unf .UNF .unif .UNIF .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\nestopia_libretro.dll %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\nestopia_libretro.dll %ROM%</command>
<platform>nes, famicom</platform> <platform>famicom</platform>
<theme>famicom</theme> <theme>famicom</theme>
</system> </system>
<system> <system>
@ -421,7 +421,7 @@
<path>%ROMPATH%\genesis</path> <path>%ROMPATH%\genesis</path>
<extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension> <extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\genesis_plus_gx_libretro.dll %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\genesis_plus_gx_libretro.dll %ROM%</command>
<platform>genesis, megadrive</platform> <platform>genesis</platform>
<theme>genesis</theme> <theme>genesis</theme>
</system> </system>
<system> <system>
@ -538,7 +538,7 @@
<path>%ROMPATH%\megadrive</path> <path>%ROMPATH%\megadrive</path>
<extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension> <extension>.mdx .MDX .md .MD .smd .SMD .gen .GEN .bin .BIN .cue .CUE .iso .ISO .sms .SMS .gg .GG .sg .SG .68k .68K .chd .CHD .7z .7Z .zip .ZIP</extension>
<command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\genesis_plus_gx_libretro.dll %ROM%</command> <command>%EMULATOR_RETROARCH% -L %CORE_RETROARCH%\genesis_plus_gx_libretro.dll %ROM%</command>
<platform>megadrive, genesis</platform> <platform>megadrive</platform>
<theme>megadrive</theme> <theme>megadrive</theme>
</system> </system>
<system> <system>