Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-29 09:35:39 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #94 from jrassa/gamelist-view-check

Browse source 
don't enable video view if current theme doesn't support it
This commit is contained in:
Jools Wills 2017-03-07 20:13:37 +00:00 committed by GitHub
parent 69b2a68cc5 e2374271f2
commit 0bb7134b5d
3 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
es-app/src/views/ViewController.cpp
View file

@ -228,13 +228,15 @@ std::shared_ptr<IGameListView> ViewController::getGameListView(SystemData* syste
//if we didn't, make it, remember it, and return it //if we didn't, make it, remember it, and return it
std::shared_ptr<IGameListView> view; std::shared_ptr<IGameListView> view;
bool themeHasVideoView = system->getTheme()->hasView("video");
//decide type //decide type
bool detailed = false; bool detailed = false;
bool video = false; bool video = false;
std::vector<FileData*> files = system->getRootFolder()->getFilesRecursive(GAME | FOLDER); std::vector<FileData*> files = system->getRootFolder()->getFilesRecursive(GAME | FOLDER);
for(auto it = files.begin(); it != files.end(); it++) for(auto it = files.begin(); it != files.end(); it++)
{ {
if(!(*it)->getVideoPath().empty()) if(themeHasVideoView && !(*it)->getVideoPath().empty())
{ {
video = true; video = true;
break; break;

5
es-core/src/ThemeData.cpp
View file

@ -343,6 +343,11 @@ void ThemeData::parseElement(const pugi::xml_node& root, const std::map<std::str
} }
} }
bool ThemeData::hasView(const std::string& view)
{
auto viewIt = mViews.find(view);
return (viewIt != mViews.end());
}
const ThemeData::ThemeElement* ThemeData::getElement(const std::string& view, const std::string& element, const std::string& expectedType) const const ThemeData::ThemeElement* ThemeData::getElement(const std::string& view, const std::string& element, const std::string& expectedType) const
{ {

2
es-core/src/ThemeData.h
View file

@ -135,6 +135,8 @@ public:
BOOLEAN BOOLEAN
}; };
bool hasView(const std::string& view);
// If expectedType is an empty string, will do no type checking. // If expectedType is an empty string, will do no type checking.
const ThemeElement* getElement(const std::string& view, const std::string& element, const std::string& expectedType) const; const ThemeElement* getElement(const std::string& view, const std::string& element, const std::string& expectedType) const;