Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-22 06:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

(Android) Added a temporary workaround to avoid crashes on non-character keyboard input when editing text

Browse source
This commit is contained in:
Leon Styhre 2024-10-27 22:46:05 +01:00
parent 4af72384db
commit 0cd15194b4
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
es-core/src/resources/Font.cpp
View file

@ -332,8 +332,22 @@ TextCache* Font::buildTextCache(const std::string& text,
Glyph* glyph {nullptr};
// Invalid character.
if (!segment.doShape && character == 0)
if (!segment.doShape && character == 0) {
if (needGlyphsPos) {
// TODO: This is a temporary workaround for a problem that only seems to be
// present on Android, and that is that non-character input from a physical
// keyboard generates SDL_TEXTINPUT events even though it shouldn't. This
// workaround is not a proper fix, it's only there to prevent ES-DE from
// crashing if such input is received when editing text. The issue has been
// reported to the SDL developers as it needs to be addressed there.
if (glyphPositions.size() > 0)
glyphPositions.emplace_back(glyphPositions.back().x,
glyphPositions.back().y);
else
glyphPositions.emplace_back(0.0f, 0.0f);
}
continue;
}
if (!segment.doShape && character == '\n') {
x = 0.0f;