Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-21 21:55:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added workarounds for some mobile GPUs which do not support all OpenGL operations when using the BGRA pixel format

Browse source
This commit is contained in:
Leon Styhre 2023-11-20 21:33:16 +01:00
parent 8fe027e9ad
commit 27be4007a2
7 changed files with 42 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
es-core/src/components/ImageComponent.cpp
View file

@ -462,6 +462,15 @@ void ImageComponent::render(const glm::mat4& parentTrans)
}
mVertices->shaderFlags = mVertices->shaderFlags | Renderer::ShaderFlags::PREMULTIPLIED;
#if defined(USE_OPENGLES)
// This is required as not all mobile GPUs support mipmapping when using the BGRA
// pixel format.
if (mMipmapping)
mVertices->shaderFlags =
mVertices->shaderFlags | Renderer::ShaderFlags::CONVERT_PIXEL_FORMAT;
#endif
mRenderer->drawTriangleStrips(&mVertices[0], 4);
}
else {

3
es-core/src/renderers/Renderer.h
View file

@ -55,7 +55,8 @@ public:
CLIPPING = 0x00000008,
ROTATED = 0x00000010, // Screen rotated 90 or 270 degrees.
ROUNDED_CORNERS = 0x00000020,
ROUNDED_CORNERS_NO_AA = 0x00000040
ROUNDED_CORNERS_NO_AA = 0x00000040,
CONVERT_PIXEL_FORMAT = 0x00000080
};
// clang-format on

23
es-core/src/renderers/RendererOpenGL.cpp
View file

@ -439,8 +439,16 @@ unsigned int RendererOpenGL::createTexture(const unsigned int texUnit,
static_cast<GLfloat>(GL_NEAREST)));
#if defined(USE_OPENGLES)
GL_CHECK_ERROR(glTexImage2D(GL_TEXTURE_2D, 0, textureType, width, height, 0, textureType,
GL_UNSIGNED_BYTE, data));
if (mipmapping) {
// This is required as not all mobile GPUs support mipmapping when using the BGRA
// pixel format.
GL_CHECK_ERROR(glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0, GL_RGBA,
GL_UNSIGNED_BYTE, data));
}
else {
GL_CHECK_ERROR(glTexImage2D(GL_TEXTURE_2D, 0, textureType, width, height, 0, textureType,
GL_UNSIGNED_BYTE, data));
}
#else
GL_CHECK_ERROR(glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, width, height, 0, textureType,
GL_UNSIGNED_BYTE, data));
@ -644,6 +652,13 @@ void RendererOpenGL::shaderPostprocessing(unsigned int shaders,
vertices->blurStrength = parameters.blurStrength;
vertices->shaderFlags = ShaderFlags::POST_PROCESSING | ShaderFlags::PREMULTIPLIED;
#if defined(USE_OPENGLES)
// This is required as not all mobile GPUs support the glReadPixels() function when using
// the BGRA pixel format.
if (textureRGBA)
vertices->shaderFlags |= ShaderFlags::CONVERT_PIXEL_FORMAT;
#endif
if (screenRotation == 90 || screenRotation == 270)
vertices->shaderFlags |= ShaderFlags::ROTATED;
@ -774,10 +789,10 @@ void RendererOpenGL::shaderPostprocessing(unsigned int shaders,
#if defined(USE_OPENGLES)
if (screenRotation == 0 || screenRotation == 180)
GL_CHECK_ERROR(
glReadPixels(0, 0, width, height, GL_BGRA_EXT, GL_UNSIGNED_BYTE, textureRGBA));
glReadPixels(0, 0, width, height, GL_RGBA, GL_UNSIGNED_BYTE, textureRGBA));
else
GL_CHECK_ERROR(
glReadPixels(0, 0, height, width, GL_BGRA_EXT, GL_UNSIGNED_BYTE, textureRGBA));
glReadPixels(0, 0, height, width, GL_RGBA, GL_UNSIGNED_BYTE, textureRGBA));
#else
if (screenRotation == 0 || screenRotation == 180)
GL_CHECK_ERROR(

1
resources/shaders/glsl/blur_horizontal.glsl
View file

@ -41,6 +41,7 @@ out vec4 FragColor;
// 0x00000010 - Screen rotated 90 or 270 degrees
// 0x00000020 - Rounded corners
// 0x00000040 - Rounded corners with no anti-aliasing
// 0x00000080 - Convert pixel format
void main()
{

1
resources/shaders/glsl/blur_vertical.glsl
View file

@ -41,6 +41,7 @@ out vec4 FragColor;
// 0x00000010 - Screen rotated 90 or 270 degrees
// 0x00000020 - Rounded corners
// 0x00000040 - Rounded corners with no anti-aliasing
// 0x00000080 - Convert pixel format
void main()
{

10
resources/shaders/glsl/core.glsl
View file

@ -59,6 +59,7 @@ out vec4 FragColor;
// 0x00000010 - Screen rotated 90 or 270 degrees
// 0x00000020 - Rounded corners
// 0x00000040 - Rounded corners with no anti-aliasing
// 0x00000080 - Convert pixel format
void main()
{
@ -74,7 +75,14 @@ void main()
discard;
}
vec4 sampledColor = texture(textureSampler0, texCoord);
vec4 sampledColor;
// Pixel format conversion is sometimes required as not all mobile GPUs support all
// OpenGL operations in BGRA format.
if (0x0u != (shaderFlags & 0x80u))
sampledColor.bgra = texture(textureSampler0, texCoord);
else
sampledColor = texture(textureSampler0, texCoord);
// Rounded corners.
if (0x0u != (shaderFlags & 0x20u) || 0x0u != (shaderFlags & 0x40u)) {

1
resources/shaders/glsl/scanlines.glsl
View file

@ -102,6 +102,7 @@ uniform float OutputGamma;
// 0x00000010 - Screen rotated 90 or 270 degrees
// 0x00000020 - Rounded corners
// 0x00000040 - Rounded corners with no anti-aliasing
// 0x00000080 - Convert pixel format
void main()
{