Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-25 15:45:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed an issue where entering a blank game name in the metadata editor would crash the application.

Browse source
This commit is contained in:
Leon Styhre 2020-07-26 15:50:40 +02:00
parent 496e653ae7
commit 47523ba627
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
NEWS.md
View file

@ -46,4 +46,5 @@ v1.0.0
* SystemView didn't properly loop the systems if only two systems were available * SystemView didn't properly loop the systems if only two systems were available
* Hidden files still showed up if they had a gamelist.xml entry * Hidden files still showed up if they had a gamelist.xml entry
* On Unix, adding a hidden folder with a game in it crashed the application on startup * On Unix, adding a hidden folder with a game in it crashed the application on startup
* If the user tried to enter a blank game name in the metadata editor, the application would crash upon saving
* Lots and lots of small bugs and inconsistencies fixed * Lots and lots of small bugs and inconsistencies fixed

8
es-app/src/guis/GuiMetaDataEd.cpp
View file

@ -287,8 +287,16 @@ void GuiMetaDataEd::save()
if (mMetaDataDecl.at(i).isStatistic) if (mMetaDataDecl.at(i).isStatistic)
continue; continue;
// If the user has entered a blank game name, then set the name to the ROM
// filename (minus the extension).
if (mMetaDataDecl.at(i).key == "name" && mEditors.at(i)->getValue() == "") {
mMetaData->set(mMetaDataDecl.at(i).key,
Utils::FileSystem::getStem(mScraperParams.game->getPath()));
}
else {
mMetaData->set(mMetaDataDecl.at(i).key, mEditors.at(i)->getValue()); mMetaData->set(mMetaDataDecl.at(i).key, mEditors.at(i)->getValue());
} }
}
// Enter game in index. // Enter game in index.
mScraperParams.system->getIndex()->addToIndex(mScraperParams.game); mScraperParams.system->getIndex()->addToIndex(mScraperParams.game);