Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-25 15:45:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

(Windows) Fixed an issue where the media viewer could crash if attempting to display corrupt or invalid PDF game manuals

Browse source
This commit is contained in:
Leon Styhre 2023-08-11 19:36:26 +02:00
parent 73522bcb6c
commit 60f0f64b57
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
es-app/src/PDFViewer.cpp
View file

@ -244,9 +244,6 @@ bool PDFViewer::getDocumentInfo()
return false; return false;
} }
// Close process and thread handles.
CloseHandle(pi.hProcess);
CloseHandle(pi.hThread);
CloseHandle(childStdoutWrite); CloseHandle(childStdoutWrite);
std::array<char, 512> buffer {}; std::array<char, 512> buffer {};
@ -268,6 +265,18 @@ bool PDFViewer::getDocumentInfo()
CloseHandle(childStdoutRead); CloseHandle(childStdoutRead);
WaitForSingleObject(pi.hThread, INFINITE); WaitForSingleObject(pi.hThread, INFINITE);
WaitForSingleObject(pi.hProcess, INFINITE); WaitForSingleObject(pi.hProcess, INFINITE);
DWORD exitCode {0};
if (GetExitCodeProcess(pi.hProcess, &exitCode) && exitCode != 0) {
LOG(LogError) << "Couldn't read PDF document information";
CloseHandle(pi.hProcess);
CloseHandle(pi.hThread);
return false;
}
// Close process and thread handles.
CloseHandle(pi.hProcess);
CloseHandle(pi.hThread);
#else #else
FILE* commandPipe; FILE* commandPipe;
std::array<char, 512> buffer {}; std::array<char, 512> buffer {};