From 7832c4fbe0c0db12ee3bbebdf9cdfa491b5219c2 Mon Sep 17 00:00:00 2001 From: Leon Styhre Date: Sat, 10 Oct 2020 15:13:47 +0200 Subject: [PATCH] Fixed an issue where hidden metadata fields would sometimes be shown. --- es-app/src/views/gamelist/DetailedGameListView.cpp | 7 ++++++- es-app/src/views/gamelist/DetailedGameListView.h | 3 +-- es-app/src/views/gamelist/VideoGameListView.cpp | 1 + 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/es-app/src/views/gamelist/DetailedGameListView.cpp b/es-app/src/views/gamelist/DetailedGameListView.cpp index ebbb07c1f..f3c7e573d 100644 --- a/es-app/src/views/gamelist/DetailedGameListView.cpp +++ b/es-app/src/views/gamelist/DetailedGameListView.cpp @@ -123,7 +123,6 @@ DetailedGameListView::DetailedGameListView( initMDLabels(); initMDValues(); - updateInfoPanel(); } void DetailedGameListView::onThemeChanged(const std::shared_ptr& theme) @@ -391,3 +390,9 @@ std::vector DetailedGameListView::getMDValues() ret.push_back(&mPlayCount); return ret; } + +void DetailedGameListView::onShow() +{ + GuiComponent::onShow(); + updateInfoPanel(); +} diff --git a/es-app/src/views/gamelist/DetailedGameListView.h b/es-app/src/views/gamelist/DetailedGameListView.h index a5e446958..8613302a5 100644 --- a/es-app/src/views/gamelist/DetailedGameListView.h +++ b/es-app/src/views/gamelist/DetailedGameListView.h @@ -19,10 +19,9 @@ class DetailedGameListView : public BasicGameListView public: DetailedGameListView(Window* window, FileData* root); + virtual void onShow() override; virtual void onThemeChanged(const std::shared_ptr& theme) override; - virtual const char* getName() const override { return "detailed"; } - virtual void launch(FileData* game) override; private: diff --git a/es-app/src/views/gamelist/VideoGameListView.cpp b/es-app/src/views/gamelist/VideoGameListView.cpp index ad641883a..e040009eb 100644 --- a/es-app/src/views/gamelist/VideoGameListView.cpp +++ b/es-app/src/views/gamelist/VideoGameListView.cpp @@ -249,6 +249,7 @@ void VideoGameListView::initMDValues() values[i]->setDefaultZIndex(40); float testBot = values[i]->getPosition().y() + values[i]->getSize().y(); + if (testBot > bottom) bottom = testBot; }