Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-22 06:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

(Linux) Yet another ugly hack to detect installed emulators when running as a Flatpak.

Browse source
This commit is contained in:
Leon Styhre 2022-04-27 17:33:43 +02:00
parent 9a91e782fc
commit 7eecf6bb41
1 changed files with 38 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

45
es-core/src/utils/FileSystemUtil.cpp
View file

@ -20,6 +20,7 @@
#include "utils/FileSystemUtil.h"
#include "Log.h"
#include "utils/PlatformUtil.h"
#include "utils/StringUtil.h"
#include <fstream>
@ -256,15 +257,44 @@ namespace Utils
return "";
#else
#if defined(FLATPAK_BUILD)
// Ugly hack for the Flatpak build to find emulators installed as Flatpaks and Snaps.
// Note that due to limitations of this package format anything installed under /usr
// and similar system directories will not be possible to launch as they are shadowed
// by the Flatpak sandbox directories. Therefore they are excluded here.
std::string pathVariable {
"/var/lib/flatpak/exports/bin:/snap/bin:/var/lib/snapd/snap/bin"};
// Ugly hack to compensate for the Flatpak sandbox restrictions. We traverse
// this hardcoded list of paths and use the "which" command to check outside the
// sandbox if the emulator binary exists.
std::string pathVariable {"/var/lib/flatpak/exports/bin:/usr/bin:/usr/local/"
"bin:/usr/local/sbin:/usr/sbin:/sbin:/bin:/usr/games:/usr/"
"local/games:/snap/bin:/var/lib/snapd/snap/bin"};
std::vector<std::string> pathList {
Utils::String::delimitedStringToVector(pathVariable, ":")};
// Using a temporary file is the only viable solution I've found to communicate
// between the sandbox and the outside world.
std::string tempFile {Utils::FileSystem::getHomePath() + "/.emulationstation/" +
".flatpak_emulator_binary_path.tmp"};
std::string emulatorPath;
for (auto it = pathList.cbegin(); it != pathList.cend(); ++it) {
Utils::Platform::runSystemCommand("flatpak-spawn --host which " + *it + "/" +
executable + " > " + tempFile);
std::ifstream tempFileStream;
tempFileStream.open(tempFile);
getline(tempFileStream, emulatorPath);
tempFileStream.close();
if (emulatorPath != "") {
emulatorPath = getParent(emulatorPath);
break;
}
}
if (exists(tempFile))
removeFile(tempFile);
return emulatorPath;
#else
std::string pathVariable {std::string(getenv("PATH"))};
#endif
std::vector<std::string> pathList {
Utils::String::delimitedStringToVector(pathVariable, ":")};
@ -277,6 +307,7 @@ namespace Utils
return it->c_str();
}
return "";
#endif
#endif
}