Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2025-02-16 20:15:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Changed some string::compare functions to == operators.

Browse source 
Also removed an unused theme property.
This commit is contained in:
Leon Styhre 2022-02-11 18:39:16 +01:00
parent 5aa8303ae6
commit 85cb10d71a
4 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
es-app/src/views/GamelistLegacy.h
View file

@ -503,17 +503,17 @@ void GamelistView::legacyUpdateInfoPanel()
BadgeComponent::BadgeInfo badgeInfo;
badgeInfo.badgeType = badge;
if (badge == "controller") {
if (file->metadata.get("controller").compare("") != 0) {
if (file->metadata.get("controller") != "") {
badgeInfo.gameController = file->metadata.get("controller");
badgeSlots.push_back(badgeInfo);
}
}
else if (badge == "altemulator") {
if (file->metadata.get(badge).compare("") != 0)
if (file->metadata.get(badge) != "")
badgeSlots.push_back(badgeInfo);
}
else {
if (file->metadata.get(badge).compare("true") == 0)
if (file->metadata.get(badge) == "true")
badgeSlots.push_back(badgeInfo);
}
}

6
es-app/src/views/GamelistView.cpp
View file

@ -593,17 +593,17 @@ void GamelistView::updateInfoPanel()
BadgeComponent::BadgeInfo badgeInfo;
badgeInfo.badgeType = badge;
if (badge == "controller") {
if (file->metadata.get("controller").compare("") != 0) {
if (file->metadata.get("controller") != "") {
badgeInfo.gameController = file->metadata.get("controller");
badgeSlots.push_back(badgeInfo);
}
}
else if (badge == "altemulator") {
if (file->metadata.get(badge).compare("") != 0)
if (file->metadata.get(badge) != "")
badgeSlots.push_back(badgeInfo);
}
else {
if (file->metadata.get(badge).compare("true") == 0)
if (file->metadata.get(badge) == "true")
badgeSlots.push_back(badgeInfo);
}
}

6
es-app/src/views/ViewController.cpp
View file

@ -728,11 +728,11 @@ std::shared_ptr<GamelistView> ViewController::getGamelistView(SystemData* system
GamelistViewStyle selectedViewStyle = AUTOMATIC;
std::string viewPreference {Settings::getInstance()->getString("GamelistViewStyle")};
if (viewPreference.compare("basic") == 0)
if (viewPreference == "basic")
selectedViewStyle = BASIC;
if (viewPreference.compare("detailed") == 0)
else if (viewPreference == "detailed")
selectedViewStyle = DETAILED;
if (viewPreference.compare("video") == 0)
else if (viewPreference == "video")
selectedViewStyle = VIDEO;
if (selectedViewStyle == AUTOMATIC) {

1
es-core/src/ThemeData.cpp
View file

@ -257,7 +257,6 @@ std::map<std::string, std::map<std::string, ThemeData::ElementPropertyType>>
{"secondaryColor", COLOR},
{"fontPath", PATH},
{"fontSize", FLOAT},
{"scrollHide", BOOLEAN},
{"scrollSound", PATH}, // For backward compatibility with legacy themes.
{"horizontalAlignment", STRING},
{"alignment", STRING}, // For backward compatibility with legacy themes.