Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-22 06:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed some minor warnings reported by the Clang static analyzer.

Browse source
This commit is contained in:
Leon Styhre 2021-03-01 19:40:23 +01:00
parent d73d32754d
commit 9ca7e58250
3 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
es-app/src/SystemScreensaver.cpp
View file

@ -603,7 +603,7 @@ void SystemScreensaver::generateOverlayInfo()
float posY = static_cast<float>(Renderer::getWindowHeight()) * 0.02f; float posY = static_cast<float>(Renderer::getWindowHeight()) * 0.02f;
std::string favoriteChar; std::string favoriteChar;
if (mCurrentGame->getFavorite()) if (mCurrentGame && mCurrentGame->getFavorite())
favoriteChar = " " + ViewController::FAVORITE_CHAR; favoriteChar = " " + ViewController::FAVORITE_CHAR;
const std::string gameName = Utils::String::toUpper(mGameName) + favoriteChar; const std::string gameName = Utils::String::toUpper(mGameName) + favoriteChar;

2
es-app/src/views/SystemView.cpp
View file

@ -299,8 +299,6 @@ void SystemView::onCursorChanged(const CursorState& /*state*/)
} }
std::string transition_style = Settings::getInstance()->getString("TransitionStyle"); std::string transition_style = Settings::getInstance()->getString("TransitionStyle");
bool goFast = transition_style == "instant";
const float infoStartOpacity = mSystemInfo.getOpacity() / 255.f;
// To prevent ugly jumps with two systems when quickly repeating the same direction. // To prevent ugly jumps with two systems when quickly repeating the same direction.
if (mPreviousScrollVelocity != 0 && posMax == 2 && if (mPreviousScrollVelocity != 0 && posMax == 2 &&

1
es-core/src/components/ComponentGrid.cpp
View file

@ -163,7 +163,6 @@ void ComponentGrid::updateSeparators()
{ {
mSeparators.clear(); mSeparators.clear();
const unsigned int color = Renderer::convertRGBAToABGR(0xC6C7C6FF);
bool drawAll = Settings::getInstance()->getBool("DebugGrid"); bool drawAll = Settings::getInstance()->getBool("DebugGrid");
Vector2f pos; Vector2f pos;