Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2025-01-17 22:55:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Removed some projection matrix and vertices roundings which caused multiple pixel alignment issues.

Browse source
This commit is contained in:
Leon Styhre 2022-09-02 21:01:31 +02:00
parent 4ade04d760
commit a1027c2580
6 changed files with 8 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
es-core/src/components/ImageComponent.cpp
View file

@ -430,7 +430,7 @@ void ImageComponent::render(const glm::mat4& parentTrans)
return;
glm::mat4 trans {parentTrans * getTransform()};
mRenderer->setMatrix(trans, false);
mRenderer->setMatrix(trans);
if (mTexture && mOpacity > 0.0f) {
if (Settings::getInstance()->getBool("DebugImage")) {

9
es-core/src/components/TextComponent.cpp
View file

@ -204,13 +204,8 @@ void TextComponent::render(const glm::mat4& parentTrans)
mRenderer->drawRect(0.0f, 0.0f, mSize.x, mSize.y, 0x0000FF33, 0x0000FF33);
}
trans = glm::translate(trans, glm::vec3 {0.0f, std::round(yOff), 0.0f});
// Don't round vertices if scaled as it may lead to single-pixel alignment issues.
if (mScale == 1.0f)
mRenderer->setMatrix(trans, true);
else
mRenderer->setMatrix(trans, false);
trans = glm::translate(trans, glm::vec3 {0.0f, yOff, 0.0f});
mRenderer->setMatrix(trans);
// Draw the text area, where the text actually is located.
if (Settings::getInstance()->getBool("DebugText")) {

3
es-core/src/components/primary/CarouselComponent.h
View file

@ -615,9 +615,6 @@ template <typename T> void CarouselComponent<T>::render(const glm::mat4& parentT
yOff += mSize.y * mVerticalOffset;
}
xOff = std::round(xOff);
yOff = std::round(yOff);
int center {static_cast<int>(mEntryCamOffset)};
int itemInclusion {static_cast<int>(std::ceil(mMaxItemCount / 2.0f))};
bool singleEntry {numEntries == 1};

2
es-core/src/renderers/Renderer.h
View file

@ -202,7 +202,7 @@ public:
const unsigned int numVertices,
const BlendFactor srcBlendFactor = BlendFactor::SRC_ALPHA,
const BlendFactor dstBlendFactor = BlendFactor::ONE_MINUS_SRC_ALPHA) = 0;
virtual void setMatrix(const glm::mat4& matrix, bool roundVertices = true) = 0;
virtual void setMatrix(const glm::mat4& matrix) = 0;
virtual void setScissor(const Rect& scissor) = 0;
virtual void setSwapInterval() = 0;
virtual void swapBuffers() = 0;

8
es-core/src/renderers/RendererOpenGL.cpp
View file

@ -275,12 +275,10 @@ void RendererOpenGL::destroyContext()
mSDLContext = nullptr;
}
void RendererOpenGL::setMatrix(const glm::mat4& matrix, bool roundVertices)
void RendererOpenGL::setMatrix(const glm::mat4& matrix)
{
mTrans = matrix;
if (roundVertices)
mTrans[3] = glm::round(mTrans[3]);
mTrans = getProjectionMatrix() * mTrans;
// Calculate the project matrix.
mTrans = getProjectionMatrix() * matrix;
}
void RendererOpenGL::setScissor(const Rect& scissor)

2
es-core/src/renderers/RendererOpenGL.h
View file

@ -38,7 +38,7 @@ public:
bool createContext() override;
void destroyContext() override;
void setMatrix(const glm::mat4& matrix, bool roundVertices = true) override;
void setMatrix(const glm::mat4& matrix) override;
void setScissor(const Rect& scissor) override;
void setSwapInterval() override;
void swapBuffers() override;