From a149124252c3131b1f9a297be60f1254ade9f211 Mon Sep 17 00:00:00 2001 From: Leon Styhre Date: Fri, 15 Apr 2022 21:26:07 +0200 Subject: [PATCH] Fixed an issue where two BadgeComponent default values were not always set. --- es-core/src/components/BadgeComponent.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/es-core/src/components/BadgeComponent.cpp b/es-core/src/components/BadgeComponent.cpp index 1f9714160..d708a056a 100644 --- a/es-core/src/components/BadgeComponent.cpp +++ b/es-core/src/components/BadgeComponent.cpp @@ -241,6 +241,7 @@ void BadgeComponent::applyTheme(const std::shared_ptr& theme, } } + mFlexboxComponent.setLines(3); if (elem->has("lines")) { const unsigned int lines {elem->get("lines")}; if (lines < 1 || lines > 10) { @@ -251,10 +252,8 @@ void BadgeComponent::applyTheme(const std::shared_ptr& theme, mFlexboxComponent.setLines(lines); } } - else { - mFlexboxComponent.setLines(3); - } + mFlexboxComponent.setItemsPerLine(4); if (elem->has("itemsPerLine")) { const unsigned int itemsPerLine {elem->get("itemsPerLine")}; if (itemsPerLine < 1 || itemsPerLine > 10) { @@ -266,9 +265,6 @@ void BadgeComponent::applyTheme(const std::shared_ptr& theme, mFlexboxComponent.setItemsPerLine(itemsPerLine); } } - else { - mFlexboxComponent.setItemsPerLine(4); - } if (elem->has("itemMargin")) { glm::vec2 itemMargin = elem->get("itemMargin");