Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-22 22:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

InputManager: improve trigger axis calibration

Browse source 
Some drivers (such as hid-sony) configure analog triggers (L2/R2) as axes
with axis range -32768-32767, but the resting value starts at -32768,
causing an initial or light press to register erroneously as a minus
axis value.

Fix by shifting ABS_Z and ABS_RZ axes that are detected to rest at
-32768 so that they will range from 0-32767 instead.

Patch based on Jools Wills' earlier commit: https://github.com/RetroPie/EmulationStation/pull/58
This commit is contained in:
Conn O'Griofa 2018-06-08 04:40:02 +00:00
parent df60750ec9
commit b097648dde
2 changed files with 20 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
es-core/src/InputManager.cpp
View file

@ -101,7 +101,14 @@ void InputManager::addJoystickByDeviceIndex(int id)
// set up the prevAxisValues // set up the prevAxisValues
int numAxes = SDL_JoystickNumAxes(joy); int numAxes = SDL_JoystickNumAxes(joy);
mPrevAxisValues[joyId] = new int[numAxes]; mPrevAxisValues[joyId] = new int[numAxes];
std::fill(mPrevAxisValues[joyId], mPrevAxisValues[joyId] + numAxes, 0); //initialize array to 0 mInitAxisValues[joyId] = new int[numAxes];
int axis;
for (int i = 0; i< numAxes; i++) {
axis = SDL_JoystickGetAxis(joy, i);
mInitAxisValues[joyId][i] = axis;
mPrevAxisValues[joyId][i] = axis;
}
} }
void InputManager::removeJoystickByJoystickID(SDL_JoystickID joyId) void InputManager::removeJoystickByJoystickID(SDL_JoystickID joyId)
@ -198,21 +205,28 @@ InputConfig* InputManager::getInputConfigByDevice(int device)
bool InputManager::parseEvent(const SDL_Event& ev, Window* window) bool InputManager::parseEvent(const SDL_Event& ev, Window* window)
{ {
bool causedEvent = false; bool causedEvent = false;
int axis;
switch(ev.type) switch(ev.type)
{ {
case SDL_JOYAXISMOTION: case SDL_JOYAXISMOTION:
axis = ev.jaxis.value;
// Check for ABS_Z/ABS_RZ trigger axes which rest at -32768
if ((ev.jaxis.axis == 2 || ev.jaxis.axis == 5) && mInitAxisValues[ev.jaxis.which][ev.jaxis.axis] == -32768)
{
// shift to 0 - 32767.
axis = axis / 2 + 16384;
}
//if it switched boundaries //if it switched boundaries
if((abs(ev.jaxis.value) > DEADZONE) != (abs(mPrevAxisValues[ev.jaxis.which][ev.jaxis.axis]) > DEADZONE)) if((abs(axis) > DEADZONE) != (abs(mPrevAxisValues[ev.jaxis.which][ev.jaxis.axis]) > DEADZONE))
{ {
int normValue; int normValue;
if(abs(ev.jaxis.value) <= DEADZONE) if(abs(axis) <= DEADZONE)
normValue = 0; normValue = 0;
else else
if(ev.jaxis.value > 0) if(axis > 0)
normValue = 1; normValue = 1;
else else
normValue = -1; normValue = -1;
window->input(getInputConfigByDevice(ev.jaxis.which), Input(ev.jaxis.which, TYPE_AXIS, ev.jaxis.axis, normValue, false)); window->input(getInputConfigByDevice(ev.jaxis.which), Input(ev.jaxis.which, TYPE_AXIS, ev.jaxis.axis, normValue, false));
causedEvent = true; causedEvent = true;
} }

1
es-core/src/InputManager.h
View file

@ -27,6 +27,7 @@ private:
InputConfig* mCECInputConfig; InputConfig* mCECInputConfig;
std::map<SDL_JoystickID, int*> mPrevAxisValues; std::map<SDL_JoystickID, int*> mPrevAxisValues;
std::map<SDL_JoystickID, int*> mInitAxisValues;
bool initialized() const; bool initialized() const;