Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2025-01-29 19:55:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed two memory leaks in CollectionSystemManager.

Browse source
This commit is contained in:
Leon Styhre 2020-10-18 22:28:18 +02:00
parent 2eb5125d0e
commit ca696e75cd
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
es-app/src/CollectionSystemManager.cpp
View file

@ -90,7 +90,7 @@ CollectionSystemManager::~CollectionSystemManager()
if (SystemData::sSystemVector.size() > 0) if (SystemData::sSystemVector.size() > 0)
removeCollectionsFromDisplayedSystems(); removeCollectionsFromDisplayedSystems();
// Iterate the map. // Save and delete all custom collections.
for (std::map<std::string, CollectionSystemData>::const_iterator for (std::map<std::string, CollectionSystemData>::const_iterator
it = mCustomCollectionSystemsData.cbegin(); it = mCustomCollectionSystemsData.cbegin();
it != mCustomCollectionSystemsData.cend() ; it++) { it != mCustomCollectionSystemsData.cend() ; it++) {
@ -99,12 +99,17 @@ CollectionSystemManager::~CollectionSystemManager()
delete it->second.system; delete it->second.system;
} }
// Delete the custom collections bundle.
if (mCustomCollectionsBundle)
delete mCustomCollectionsBundle;
// Delete the auto collections systems. // Delete the auto collections systems.
for (auto it = mAutoCollectionSystemsData.cbegin(); for (auto it = mAutoCollectionSystemsData.cbegin();
it != mAutoCollectionSystemsData.cend(); it++) { it != mAutoCollectionSystemsData.cend(); it++) {
delete (*it).second.system; delete (*it).second.system;
} }
delete mCollectionEnvData;
sInstance = nullptr; sInstance = nullptr;
} }