From cb8596ab8a5bbdd951408d53b67d10f3f3174745 Mon Sep 17 00:00:00 2001
From: Leon Styhre <leon@leonstyhre.com>
Date: Sun, 10 Apr 2022 11:32:55 +0200
Subject: [PATCH] Prevented themes using the <resolution> tag from loading
 altogether.

---
 es-core/src/ThemeData.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/es-core/src/ThemeData.cpp b/es-core/src/ThemeData.cpp
index d3de108a0..30bbd70ab 100644
--- a/es-core/src/ThemeData.cpp
+++ b/es-core/src/ThemeData.cpp
@@ -388,6 +388,12 @@ void ThemeData::loadFile(const std::map<std::string, std::string>& sysDataMap,
     if (mCurrentThemeSet != mThemeSets.cend())
         mLegacyTheme = mCurrentThemeSet->second.capabilities.legacyTheme;
 
+    // The resolution tag introduced in RetroPie EmulationStation in 2020 is a very bad idea
+    // as it changes sizing of components from relative values to absolute pixel values.
+    // So themes using it will simply not get loaded at all.
+    if (root.child("resolution") != nullptr)
+        throw error << ": <resolution> tag not supported";
+
     // Check for legacy theme version.
     int legacyVersion {root.child("formatVersion").text().as_int(-1)};