Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-29 09:35:39 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Fixed a heisenbug where letters would sometimes get rendered with ugly edge artifacts.

Browse source
This commit is contained in:
Leon Styhre 2022-10-11 18:07:56 +02:00
parent add8e37687
commit d74966a3c4
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
es-core/src/resources/Font.cpp
View file

@ -519,7 +519,8 @@ bool Font::FontTexture::findEmpty(const glm::ivec2& size, glm::ivec2& cursor_out
if (writePos.x + size.x >= textureSize.x && if (writePos.x + size.x >= textureSize.x &&
writePos.y + rowHeight + size.y + 1 < textureSize.y) { writePos.y + rowHeight + size.y + 1 < textureSize.y) {
// Row is full, but the glyph should fit on the next row so move the cursor there. // Row is full, but the glyph should fit on the next row so move the cursor there.
// Leave 1px of space between glyphs. // Leave 1 pixel of space between glyphs so that pixels from adjacent glyphs will
// not get sampled during scaling which would lead to edge artifacts.
writePos = glm::ivec2 {0, writePos.y + rowHeight + 1}; writePos = glm::ivec2 {0, writePos.y + rowHeight + 1};
rowHeight = 0; rowHeight = 0;
} }
@ -528,7 +529,7 @@ bool Font::FontTexture::findEmpty(const glm::ivec2& size, glm::ivec2& cursor_out
return false; // No it still won't fit. return false; // No it still won't fit.
cursor_out = writePos; cursor_out = writePos;
// Leave 1px of space between glyphs. // Leave 1 pixel of space between glyphs.
writePos.x += size.x + 1; writePos.x += size.x + 1;
if (size.y > rowHeight) if (size.y > rowHeight)
@ -540,9 +541,13 @@ bool Font::FontTexture::findEmpty(const glm::ivec2& size, glm::ivec2& cursor_out
void Font::FontTexture::initTexture() void Font::FontTexture::initTexture()
{ {
assert(textureId == 0); assert(textureId == 0);
// Create a black texture with zero alpha value so that the single-pixel spaces between the
// glyphs will not be visible. That would otherwise lead to edge artifacts as these pixels
// would get sampled during scaling.
std::vector<uint8_t> texture(textureSize.x * textureSize.y * 4, 0);
textureId = textureId =
Renderer::getInstance()->createTexture(Renderer::TextureType::RED, true, false, false, Renderer::getInstance()->createTexture(Renderer::TextureType::RED, true, false, false,
false, textureSize.x, textureSize.y, nullptr); false, textureSize.x, textureSize.y, &texture[0]);
} }
void Font::FontTexture::deinitTexture() void Font::FontTexture::deinitTexture()