Xargon/RetroDECK
1
0
Fork 0
mirror of https://github.com/RetroDECK/RetroDECK.git synced 2025-04-10 19:15:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improve find_compatible_games logic and spelling

Browse source
This commit is contained in:
icenine451 2025-03-20 15:33:45 -04:00
parent b637ddd721
commit cf750aa58d
1 changed files with 22 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
functions/compression.sh
View file

@ -150,13 +150,13 @@ find_compatible_games() {
compression_format="$1" compression_format="$1"
fi fi
local compressable_systems_list local compressible_systems_list
if [[ "$compression_format" == "all" ]]; then if [[ "$compression_format" == "all" ]]; then
compressable_systems_list=$(jq -r '.compression_targets | to_entries[] | .value[]' "$features") compressible_systems_list=$(jq -r '.compression_targets | to_entries[] | .value[]' "$features")
log d "compressable_systems_list: $compressable_systems_list" log d "compressible_systems_list: $compressible_systems_list"
else else
compressable_systems_list=$(jq -r '.compression_targets["'"$compression_format"'"][]' "$features") compressible_systems_list=$(jq -r '.compression_targets["'"$compression_format"'"][]' "$features")
log d "compressable_systems_list: $compressable_systems_list" log d "compressible_systems_list: $compressible_systems_list"
fi fi
log d "Finding compatible games for compression ($1)" log d "Finding compatible games for compression ($1)"
@ -172,55 +172,43 @@ find_compatible_games() {
log d "Checking game: $game" log d "Checking game: $game"
local compatible_compression_format local compatible_compression_format
compatible_compression_format=$(find_compatible_compression_format "$game") compatible_compression_format=$(find_compatible_compression_format "$game")
if [[ -f "${game%.*}.$compatible_compression_format" ]]; then # If a compressed version of this game already exists
log d "Skipping $game because a $compatible_compression_format version already exists."
continue
fi
local file_ext="${game##*.}" local file_ext="${game##*.}"
case "$compression_format" in case "$compression_format" in
"chd") "chd")
if [[ "$compatible_compression_format" == "chd" ]]; then if [[ "$compatible_compression_format" == "chd" ]]; then
if [[ "$file_ext" == "chd" ]]; then
log d "Skipping $game because it is already a CHD file."
elif [[ ! -f "${game%.*}.chd" ]]; then
log d "Game $game is compatible with CHD compression" log d "Game $game is compatible with CHD compression"
echo "${game}^chd" >> "$output_file" echo "${game}^chd" >> "$output_file"
fi fi
fi
;; ;;
"zip") "zip")
if [[ "$compatible_compression_format" == "zip" ]]; then if [[ "$compatible_compression_format" == "zip" ]]; then
if [[ "$file_ext" == "zip" ]]; then
log d "Skipping $game because it is already a ZIP file."
elif [[ ! -f "${game%.*}.zip" ]]; then
log d "Game $game is compatible with ZIP compression" log d "Game $game is compatible with ZIP compression"
echo "${game}^zip" >> "$output_file" echo "${game}^zip" >> "$output_file"
fi fi
fi
;; ;;
"rvz") "rvz")
if [[ "$compatible_compression_format" == "rvz" ]]; then if [[ "$compatible_compression_format" == "rvz" ]]; then
if [[ "$file_ext" == "rvz" ]]; then
log d "Skipping $game because it is already an RVZ file."
elif [[ ! -f "${game%.*}.rvz" ]]; then
log d "Game $game is compatible with RVZ compression" log d "Game $game is compatible with RVZ compression"
echo "${game}^rvz" >> "$output_file" echo "${game}^rvz" >> "$output_file"
fi fi
fi
;; ;;
"all") "all")
if [[ "$compatible_compression_format" != "none" ]]; then if [[ "$compatible_compression_format" != "none" ]]; then
if [[ "$file_ext" == "$compatible_compression_format" ]]; then
log d "Skipping $game because it is already in $compatible_compression_format format."
else
log d "Game $game is compatible with $compatible_compression_format compression" log d "Game $game is compatible with $compatible_compression_format compression"
echo "${game}^${compatible_compression_format}" >> "$output_file" echo "${game}^${compatible_compression_format}" >> "$output_file"
fi fi
fi
;; ;;
esac esac
done < <(printf '%s\n' "$compression_candidates") done < <(printf '%s\n' "$compression_candidates")
fi fi
else else
log i "Rom folder for $system is missing, skipping" log d "Rom folder for $system is missing, skipping"
fi fi
done < <(printf '%s\n' "$compressable_systems_list") done < <(printf '%s\n' "$compressible_systems_list")
log d "Compatible games have been written to $output_file" log d "Compatible games have been written to $output_file"
cat "$output_file" cat "$output_file"
@ -262,9 +250,9 @@ cli_compress_all_games() {
local compressable_game="" local compressable_game=""
local all_compressable_games=() local all_compressable_games=()
if [[ $compression_format == "all" ]]; then if [[ $compression_format == "all" ]]; then
local compressable_systems_list=$(jq -r '.compression_targets | to_entries[] | .value[]' $features) local compressible_systems_list=$(jq -r '.compression_targets | to_entries[] | .value[]' $features)
else else
local compressable_systems_list=$(jq -r '.compression_targets["'"$compression_format"'"][]' $features) local compressible_systems_list=$(jq -r '.compression_targets["'"$compression_format"'"][]' $features)
fi fi
read -p "Do you want to have the original files removed after compression is complete? Please answer y/n and press Enter: " post_compression_cleanup read -p "Do you want to have the original files removed after compression is complete? Please answer y/n and press Enter: " post_compression_cleanup
@ -288,5 +276,5 @@ cli_compress_all_games() {
else else
log w "No compatible files found for compression in $system" log w "No compatible files found for compression in $system"
fi fi
done < <(printf '%s\n' "$compressable_systems_list") done < <(printf '%s\n' "$compressible_systems_list")
} }