Xargon/Supermodel
1
0
Fork 0
mirror of https://github.com/RetroDECK/Supermodel.git synced 2024-11-22 13:55:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

slightly optimize DrawTileLine (less branches/logic)

Browse source
This commit is contained in:
toxieainc 2022-07-11 18:49:02 +02:00
parent b98be0c2e7
commit abb1273aa0
1 changed files with 7 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
Src/Graphics/Render2D.cpp
View file

@ -333,23 +333,13 @@ static inline void DrawTileLine(uint32_t *line, int pixelOffset, uint16_t tile,
uint32_t pattern = vram[patternOffset + patternLine]; uint32_t pattern = vram[patternOffset + patternLine];
for (int p = 7; p >= 0; p--) for (int p = 7; p >= 0; p--)
{ {
if (!clip || (clip && pixelOffset >= 0 && pixelOffset < 496)) if (!clip || (/*pixelOffset >= 0 &&*/ (unsigned int)pixelOffset < 496u))
{ {
uint16_t maskTest = 1 << (15-((pixelOffset+0)/32)); uint16_t maskTest = 1 << (15-((pixelOffset+0)/32));
bool visible = (mask & maskTest) != 0; bool visible = (mask & maskTest) != 0;
uint32_t pixel = palette[((pattern >> (p*4)) & 0xF) | colorHi]; uint32_t pixel = visible ? palette[((pattern >> (p*4)) & 0xF) | colorHi] : 0;
if (alphaTest) if (!alphaTest || (visible && (pixel >> 24) != 0)) // only draw opaque pixels
{
if (visible && (pixel >> 24) != 0) // only draw opaque pixels
line[pixelOffset] = pixel; line[pixelOffset] = pixel;
}
else
{
if (visible)
line[pixelOffset] = pixel;
else
line[pixelOffset] = 0;
}
} }
++pixelOffset; ++pixelOffset;
} }
@ -361,23 +351,13 @@ static inline void DrawTileLine(uint32_t *line, int pixelOffset, uint16_t tile,
uint32_t pattern = vram[patternOffset + patternLine + i]; uint32_t pattern = vram[patternOffset + patternLine + i];
for (int p = 3; p >= 0; p--) for (int p = 3; p >= 0; p--)
{ {
if (!clip || (clip && pixelOffset >= 0 && pixelOffset < 496)) if (!clip || (/*pixelOffset >= 0 &&*/ (unsigned int)pixelOffset < 496u))
{ {
uint16_t maskTest = 1 << (15-((pixelOffset+0)/32)); uint16_t maskTest = 1 << (15-((pixelOffset+0)/32));
bool visible = (mask & maskTest) != 0; bool visible = (mask & maskTest) != 0;
uint32_t pixel = palette[((pattern >> (p*8)) & 0xFF) | colorHi]; uint32_t pixel = visible ? palette[((pattern >> (p*8)) & 0xFF) | colorHi] : 0;
if (alphaTest) if (!alphaTest || (visible && (pixel >> 24) != 0))
{
if (visible && (pixel >> 24) != 0)
line[pixelOffset] = pixel; line[pixelOffset] = pixel;
}
else
{
if (visible)
line[pixelOffset] = pixel;
else
line[pixelOffset] = 0; // transparent
}
} }
++pixelOffset; ++pixelOffset;
} }
@ -417,12 +397,11 @@ static void DrawLayer(uint32_t *pixels, int layerNum, const uint32_t *vram, cons
int extraTile = (hFine != 0) ? 1 : 0; // h-scrolling requires part of 63rd tile int extraTile = (hFine != 0) ? 1 : 0; // h-scrolling requires part of 63rd tile
// First tile may be clipped // First tile may be clipped
int tx = 0;
DrawTileLine<bits, alphaTest, true>(line, pixelOffset, nameTable[(hTile ^ 1) & 63], vFine, vram, palette, mask); DrawTileLine<bits, alphaTest, true>(line, pixelOffset, nameTable[(hTile ^ 1) & 63], vFine, vram, palette, mask);
++hTile; ++hTile;
pixelOffset += 8; pixelOffset += 8;
// Middle tiles will not be clipped // Middle tiles will not be clipped
for (tx = 1; tx < (62 - 1 + extraTile); tx++) for (int tx = 1; tx < (62 - 1 + extraTile); tx++)
{ {
DrawTileLine<bits, alphaTest, false>(line, pixelOffset, nameTable[(hTile ^ 1) & 63], vFine, vram, palette, mask); DrawTileLine<bits, alphaTest, false>(line, pixelOffset, nameTable[(hTile ^ 1) & 63], vFine, vram, palette, mask);
++hTile; ++hTile;