Commit graph

259 commits

Author SHA1 Message Date
Ian Curtis bddc86aba9 The vertex shader is run before clipping is done. If fogging values are calculated and clamped in the vertex shader it can interpolate bad values, since the range has been truncated. This happens if the polys overlap the near plane. The solution to clamp the values in the fragment shader. This fixes a bunch of fogging errors I long thought were transparency related errors in the ocean hunter. 2017-11-20 22:21:15 +00:00
Ian Curtis bc7f1e9fac Fixed shading also works with untextured polys. Fixes some shading issues in La machineguns. (Harry Tuttle) 2017-11-07 00:15:57 +00:00
Ian Curtis df44ad458b Update step 1.5 luminous logic with Harry's findings. Fixes various shading issues. 2017-11-05 13:25:33 +00:00
Ian Curtis 8e13c3bbb9 Finish the hash function (Harry Tuttle) 2017-10-19 20:48:53 +00:00
Ian Curtis 7f6df0cc84 Remove fixed shading check from specular. 2017-10-07 12:39:30 +00:00
Ian Curtis eb798ed15e Star wars is the only game to pass unsigned fixed shaded values (per vertex brightness) to the renderer. Originally we thought that the specular flag would turn on unsigned values since it's the only game to set specular with these polys, but this logic turned out to be incorrect. The JTAG interface seems to config the GPU to turn on this functionality. (Harry Tuttle) 2017-10-05 19:15:00 +00:00
Ian Curtis 43cf6b3bbf update spotlight code (Harry Tuttle) 2017-10-05 18:49:08 +00:00
Ian Curtis 9bac7836ed add missing header 2017-09-30 19:05:04 +00:00
Ian Curtis 0afd9026dc Fix the sky in one of the levels in virtua on. The problem was caused by the fact we didn't split the mesh by the fog % burn through, so all the polys had the same value. We could use a vertex attrib, but % burn through fog is so rarely used and when it is, normally every poly in the mesh has the same value. 2017-09-26 00:30:08 +00:00
Bart Trzynadlowski 55bb02d4e5 - New work-in-progress frame timing code (disabled by default, compile with NEW_FRAME_TIMING defined to activate it)
- New JTAG emulation, moved into its own class, CJTAG
- Removed game-specific sun clamp hacks from CNew3D (JTAG and Real3D emulation will call the appropriate method to configure this at run-time)
- Removed JTAG from Real3D save state data and reused some of that space for new state variables having to do with the internal JTAG-based config as well as new frame timing state variables
2017-09-24 20:52:48 +00:00
Ian Curtis a3e2fb7906 Calculating the length of the vertex results in quite broken values for fogging when the vertices are traversing the view frustum. The hardware also wouldn't have been doing a square root per vertex for fogging. Simply using the z values is enough. Todo check clamping of values for the near/far planes. 2017-09-06 13:07:39 +00:00
Ian Curtis 2786d95795 add interface for sun clamp 2017-09-02 14:54:16 +00:00
Ian Curtis 266c911133 Optimise vertex data to cut down on unnecessary copying 2017-08-30 21:45:25 +00:00
Ian Curtis 165926aa06 Modern hardware does backface culling in window space by calculating the face normal for the polygon, then doing a dot product against the view vector. The real3d pro-1000 on the other hand passes a pre-calculated face normal for each polygon which is used for culling. We were using this face normal to rewind the polygons so that regular backface culling would work. This worked 99.9% of the time. However this was failing on some models in Virtua Striker. The reason was because the pre-calculated face normals being passed were actually completely different to the actual face normals for the poly (not just inverted like you would expect). This broke our code. The solution was to emulate face culling directly in the vertex shader using the pre-calculated face normals directly. Only minimally tested this but hopefully there are no obvious regressions. 2017-08-29 10:27:29 +00:00
Ian Curtis 50d1f95648 Changed fixed shaded logic for step 1.5 hw based upon Harry's findings 2017-08-25 22:40:39 +00:00
Ian Curtis b21ed49512 cosmetic 2017-08-21 23:00:29 +00:00
Ian Curtis cd5978773a Harry made some important discoveries with regards to fixed shading on the model 3 (per vertex poly brightness values). Firstly values are allowed to be negative, and they are used as a drop in replacement in the standard lighting equation for the normal dot light vector. This quite radically changes the brightness in LA Machine guns, but now correctly matches the arcade. 2017-08-19 20:06:31 +00:00
Ian Curtis 0efd4dac39 Finish fixed shading for 2.0 hardware. I'm pretty sure it actually works identically to step 1.5 hardware. The oddball is LA machine guns where the viewport ambient doesn't seem to effect the brightness. But the ambient works differently in this game because it uses the unclamped light model. Still need to investigate if the diffuse factor effects fixed shading. 2017-08-15 23:21:57 +00:00
Ian Curtis b1cc9a615d With fixed shading, when lighting is disabled, fixed shading appears to be a flat shaded version based upon the poly colour, instead of per vertex attributes. 2017-08-15 20:50:36 +00:00
Ian Curtis 2422caadc6 Pad struct and align on 4 byte boundary. 2017-08-15 20:45:08 +00:00
Ian Curtis eac76f0908 simplify 2017-08-14 23:30:34 +00:00
Ian Curtis 81188bee07 fixed shading doesn't effect the alpha channel 2017-08-14 16:10:26 +00:00
Ian Curtis c12e4c3215 Fixed shading (per vertex poly colours) on step 1.5 hardware have the viewport ambient value added to them. This fixes various shading on scud. To do this had to switch the maths to the vertex shader. 2017-08-14 09:14:06 +00:00
Ian Curtis 8f622714a7 Fix attribute locations. glBindAttribLocation must be called linking 2017-08-11 11:59:41 +00:00
Bart Trzynadlowski a315627401 Added support for loading shaders from files for new engine and tile renderer. Changed help text to reflect new engine being default. 2017-08-11 00:41:10 +00:00
Ian Curtis d7403afda6 use generic vertex attributes 2017-08-10 15:43:03 +00:00
Ian Curtis 57d0a513fd Technically matrix casts are only allowed in glsl 1.2 and later 2017-08-09 23:25:01 +00:00
Ian Curtis 5709ee2659 Sometime ago I managed to work out that specular on the model3 is not real specular, and really is just an extension of diffuse lighting. But attempts were derailed by corner cases and the fact we were not handling the normals correctly. Anyway Harry managed to successfully come up with an algorithm, and coefficients that give an almost perfect match to specular on the model3, based soley on observations from video footage! He also worked out that the lighting on hardware 1.5 onwards appears to be unclamped (ie greater than 1). This quite radically changes the brightness of some of the games, but much better matches the original hardware. 2017-08-09 16:56:56 +00:00
Ian Curtis 1d338877fc cosmetic 2017-08-03 11:05:04 +00:00
Ian Curtis 3fc28159eb Add the unclamped light model we know exists to the shaders. 2017-08-03 10:41:18 +00:00
Ian Curtis b1bd877b82 Ski champ for some reason is passing denormalised numbers for the modelscale. This is causing a NaN in our shader killing the lighting for these models, so we simply skip these, since they are essentially zero anyway. Thanks to Harry for finding this bug :) 2017-08-01 23:48:53 +00:00
Ian Curtis 9aa3f13777 We were force normalising the result of matrix * normal, which looked correct in most cases. But this didn't preserve the scaling of the matrix, or the scaling of the model normals which resulted in many over bright areas. On it's own this generally worked, but games like Star Wars looked quite broken. Harry correctly figured out if you scale these normals by the scaling value that is sometimes present in the culling nodes the lighting looks correct. Still more work to do to correctly figure out the model3's lighting model. 2017-07-29 16:30:30 +00:00
Ian Curtis a9b49c1676 Implement unclamped light model based upon Harry's findings. Unknown how this is turned on/off. 2017-07-22 17:15:14 +00:00
Ian Curtis 2335f3173b Use c++11 raw string literals 2017-07-08 10:55:14 +00:00
Ian Curtis 3efb055344 Clamp the ambient light to a max of 0.75. LA Machine guns seems to use an ambient value of 1, which is full bright for everything. But for some reason the hardware seems to treat this as ~ 0.75. This fixes various missing shading in the game. This doesn't seem to have any negative effects on other games I have tested. Clamping in the shader as we might need the full range of values for fixed shading. 2017-06-29 19:05:30 +00:00
Ian Curtis 9e9a549283 remove WIP code 2017-06-25 20:09:45 +00:00
Ian Curtis ec3872d108 convert sun angle coordinate system outside of the shader 2017-06-25 19:50:02 +00:00
Ian Curtis 97781108e8 A second go at fixing the fixed lighting in star wars .. Fixed shading is per vertex poly colours. For some reason in star wars they are treated as unsigned values instead of signed, like in every other game. These polys are all marked with specular enabled, where as in the rest of the games they are missing this flag. That's the only difference I can find. 2017-06-21 17:04:53 +00:00
Ian Curtis 1532168af7 fix double offset 2017-06-20 21:44:58 +00:00
Ian Curtis b00315b072 Revert previous fixed shading changes. Implement new logic for fixed shading on step 1.5 hardware based upon Harry's findings. 2017-06-20 20:13:42 +00:00
Ian Curtis bb3c538808 remove debug code 2017-06-20 19:46:06 +00:00
Ian Curtis 260daa1b91 Fix the fix shading in star wars. Fixed shading still needs some work for mag truck and dirt devils to match the arcade. 2017-06-17 16:05:54 +00:00
Ian Curtis 73a7d2760d cosmetic 2017-06-07 23:16:22 +00:00
Ian Curtis 1193069709 Tweak scroll fog logic again .. should fix missing 2d fogging in Spikeout. 2017-06-07 23:14:01 +00:00
Ian Curtis 45741b24d2 rewrite scroll fog logic 2017-05-06 16:47:31 +00:00
Ian Curtis 80004b0dad Remove debug code 2017-04-25 00:31:39 +00:00
Ian Curtis 7694e4eb0c minor culling node optimisations 2017-04-25 00:10:55 +00:00
Ian Curtis ff936c588b don't need cast, conversion is implicit 2017-04-20 19:46:40 +00:00
Ian Curtis 912bb0e7cf better state handling 2017-04-20 19:43:41 +00:00
Ian Curtis 9b226ed478 parse out some culling node values 2017-04-17 10:40:07 +00:00