Making review changes

0.244-selgame-assert-when-zero.patch

@@ -0,0 +1,13 @@
+diff --git a/src/frontend/mame/ui/selgame.cpp b/src/frontend/mame/ui/selgame.cpp
+index abda7047..89642d88 100644
+--- a/src/frontend/mame/ui/selgame.cpp
++++ b/src/frontend/mame/ui/selgame.cpp
+@@ -164,7 +164,7 @@ void menu_select_game::menu_activated()
+ 
+ void menu_select_game::handle(event const *ev)
+ {
+-	if (!m_prev_selected)
++	if (!m_prev_selected && item_count() > 0)
+ 		m_prev_selected = item(0).ref();
+ 
+ 	// if I have to select software, force software list submenu

README.md

@@ -26,14 +26,12 @@ An explanation for some of the options included in the `org.mamedev.MAME.yaml' m
 
 `--filesystem=host:ro` primarily to be used for external data, roms, samples, etc.
 
-`post-install` section used to copy MAME built-in directories.
-
 ### Patches
 
 Currently these are the patches applied:
 
 `0.244-ptrdiff_t.patch` includes `<cstddef>` header to find `ptrdiff_t` type in the 0.244 release.
 
-`use-system-lib-flac.patch` works around FORTIFY_SOURCE compiler option that causes errors in the included libflac.
-
 `ldopts.patch` enables an option for the linker to strip debug symbols.
+
+`use-system-lib-flac.patch` works around FORTIFY_SOURCE compiler option that causes errors in the included libflac.

org.mamedev.MAME.metainfo.xml

@@ -2,6 +2,8 @@
 <component type="desktop-application">
   <id>org.mamedev.MAME</id>
   <metadata_license>CC0-1.0</metadata_license>
+  <project_license>GPL-2.0</project_license>
+  <project_license>BSD-3-Clause</project_license>
   <name>MAME</name>
   <summary>
     MAME is a multi-purpose emulation framework.
@@ -22,4 +24,26 @@
   <provides>
     <binary>mame</binary>
   </provides>
+  <content_rating type="oars-1.0">
+    <content_attribute id="violence-cartoon">intense</content_attribute>
+    <content_attribute id="violence-fantasy">intense</content_attribute>
+    <content_attribute id="violence-realistic">intense</content_attribute>
+    <content_attribute id="violence-bloodshed">intense</content_attribute>
+    <content_attribute id="violence-sexual">intense</content_attribute>
+    <content_attribute id="drugs-alcohol">moderate</content_attribute>
+    <content_attribute id="drugs-narcotics">moderate</content_attribute>
+    <content_attribute id="drugs-tobacco">moderate</content_attribute>
+    <content_attribute id="sex-nudity">intense</content_attribute>
+    <content_attribute id="sex-themes">intense</content_attribute>
+    <content_attribute id="language-profanity">intense</content_attribute>
+    <content_attribute id="language-humor">intense</content_attribute>
+    <content_attribute id="language-discrimination">intense</content_attribute>
+    <content_attribute id="money-advertising">moderate</content_attribute>
+    <content_attribute id="money-gambling">moderate</content_attribute>
+  </content_rating>
+  <screenshots>
+    <screenshot type="default">
+        <image type="source" width="1280" height="960">https://upload.wikimedia.org/wikipedia/commons/6/6f/NewMAME.png</image>
+    </screenshot>
+  </screenshots>
 </component>

org.mamedev.MAME.yaml

@@ -25,35 +25,7 @@ modules:
       - install -Dm 0755 mame /app/bin/mame
       - install -Dm 0644 ${FLATPAK_ID}.desktop /app/share/applications/${FLATPAK_ID}.desktop
       - install -Dm 0644 ${FLATPAK_ID}.metainfo.xml /app/share/metainfo/${FLATPAK_ID}.metainfo.xml
-      - |
+      - install -Dm 0644 mame128x128.png /app/share/icons/hicolor/128x128/apps/${FLATPAK_ID}.png
-        for i in 32 48 64 128 256; do
-          install -Dm 0644 mame${i}x${i}.png /app/share/icons/hicolor/${i}x${i}/apps/${FLATPAK_ID}.png
-        done
-    sources:
-    - type: archive
-      url: https://github.com/mamedev/mame/archive/refs/tags/mame0244.tar.gz
-      sha256: 843c917edc46008a27b439a1fc66fc12a27c84e55e08753b963789e5614cebf7
-    - type: file
-      path: mame32x32.png
-    - type: file
-      path: mame48x48.png
-    - type: file
-      path: mame64x64.png
-    - type: file
-      path: mame128x128.png
-    - type: file
-      path: mame256x256.png
-    - type: file
-      path: org.mamedev.MAME.desktop
-    - type: file
-      path: org.mamedev.MAME.metainfo.xml
-    - type: patch
-      path: 0.244-ptrdiff_t.patch
-    - type: patch
-      path: use-system-lib-flac.patch
-    - type: patch
-      path: ldopts.patch
-    post-install:
       - cp COPYING /app/bin/
       - cp uismall.bdf /app/bin/
       - mkdir -p /app/share/mame/
@@ -70,3 +42,21 @@ modules:
       - cp -r plugins/ /app/share/mame/
       - cp -r roms/ /app/share/mame/
       - cp -r samples/ /app/share/mame/
+    sources:
+    - type: archive
+      url: https://github.com/mamedev/mame/archive/refs/tags/mame0244.tar.gz
+      sha256: 843c917edc46008a27b439a1fc66fc12a27c84e55e08753b963789e5614cebf7
+    - type: file
+      path: mame128x128.png
+    - type: file
+      path: org.mamedev.MAME.desktop
+    - type: file
+      path: org.mamedev.MAME.metainfo.xml
+    - type: patch
+      path: 0.244-ptrdiff_t.patch
+    - type: patch
+      path: use-system-lib-flac.patch
+    - type: patch
+      path: ldopts.patch
+    - type: patch
+      path: 0.244-selgame-assert-when-zero.patch