Xargon/Duckstation
1
0
Fork 0
mirror of https://github.com/RetroDECK/Duckstation.git synced 2024-09-17 08:02:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GPU/HW: Fix off-by-one in dirty rect checks

Browse source 
Fixes transitions in Crash 3.
This commit is contained in:
Stenzek 2024-01-08 15:41:24 +10:00
parent 95486f7972
commit fcbae6cef3
No known key found for this signature in database
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/gpu_hw.cpp
View file

@ -1474,10 +1474,8 @@ void GPU_HW::ComputePolygonUVLimits(u32 texpage, BatchVertex* vertices, u32 num_
max_v = std::max<u32>(max_v, vertices[i].v); max_v = std::max<u32>(max_v, vertices[i].v);
} }
if (min_u != max_u) max_u = (min_u != max_u) ? (max_u - 1) : max_u;
max_u--; max_v = (min_v != max_v) ? (max_v - 1) : max_v;
if (min_v != max_v)
max_v--;
CheckForTexPageOverlap(texpage, min_u, min_v, max_u, max_v); CheckForTexPageOverlap(texpage, min_u, min_v, max_u, max_v);
@ -2105,7 +2103,7 @@ ALWAYS_INLINE_RELEASE void GPU_HW::CheckForTexPageOverlap(u32 texpage, u32 min_u
if (vram_min_u < m_current_uv_range.left || vram_min_v < m_current_uv_range.top || if (vram_min_u < m_current_uv_range.left || vram_min_v < m_current_uv_range.top ||
vram_max_u >= m_current_uv_range.right || vram_max_v >= m_current_uv_range.bottom) vram_max_u >= m_current_uv_range.right || vram_max_v >= m_current_uv_range.bottom)
{ {
m_current_uv_range.Include(vram_min_u, vram_max_u, vram_min_v, vram_max_v); m_current_uv_range.Include(vram_min_u, vram_max_u + 1, vram_min_v, vram_max_v + 1);
bool update_drawn = false, update_written = false; bool update_drawn = false, update_written = false;
if (m_texpage_dirty & TEXPAGE_DIRTY_DRAWN_RECT) if (m_texpage_dirty & TEXPAGE_DIRTY_DRAWN_RECT)