Xargon/ES-DE
1
0
Fork 0
mirror of https://github.com/RetroDECK/ES-DE.git synced 2024-11-22 14:15:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Improved the detection of invalid ScreenScraper box back covers.

Browse source
This commit is contained in:
Leon Styhre 2021-10-30 10:23:55 +02:00
parent ee80792e0f
commit 5c54e52ecd
1 changed files with 35 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
es-app/src/scrapers/Scraper.cpp
View file

@ -425,11 +425,10 @@ void MediaDownloadHandle::update()
// Download is done, save it to disk. // Download is done, save it to disk.
// There's an incredibly annoying issue where some box back covers at ScreenScraper only contain // There are multiple issues with box back covers at ScreenScraper. Some only contain a single
// a single color, like pure black or more commonly pure green. The hack below checks if the // color like pure black or more commonly pure green, and some are mostly transparent with just
// same pixel value is set throughout the image and if so skips the file saving. This is not // a few black lines at the bottom. The following code attempts to detect such broken images
// very efficient but these images are not technically corrupt so the actual pixel values need // and skip them so they're not saved to disk.
// to be read and compared.
if (Settings::getInstance()->getString("Scraper") == "screenscraper" && if (Settings::getInstance()->getString("Scraper") == "screenscraper" &&
mMediaType == "backcovers") { mMediaType == "backcovers") {
bool emptyImage = false; bool emptyImage = false;
@ -446,22 +445,42 @@ void MediaDownloadHandle::update()
RGBQUAD firstPixel; RGBQUAD firstPixel;
RGBQUAD currPixel; RGBQUAD currPixel;
FreeImage_GetPixelColor(tempImage, 0, 0, &firstPixel); unsigned int width = FreeImage_GetWidth(tempImage);
unsigned int height = FreeImage_GetHeight(tempImage);
for (unsigned int x = 0; x < FreeImage_GetWidth(tempImage); x++) { // Skip really small images as they're obviously not valid.
if (!emptyImage) if (width < 50) {
break; emptyImage = true;
for (unsigned int y = 0; y < FreeImage_GetHeight(tempImage); y++) { }
FreeImage_GetPixelColor(tempImage, x, y, &currPixel); else if (height < 50) {
if (currPixel.rgbBlue != firstPixel.rgbBlue || emptyImage = true;
currPixel.rgbGreen != firstPixel.rgbGreen || }
currPixel.rgbRed != firstPixel.rgbRed) { else {
emptyImage = false; // Remove the alpha channel which will convert fully transparent pixels to black.
if (FreeImage_GetBPP(tempImage) != 24) {
FIBITMAP* convertImage = FreeImage_ConvertTo24Bits(tempImage);
FreeImage_Unload(tempImage);
tempImage = convertImage;
}
// Skip the first line as this can apparently lead to false positives.
FreeImage_GetPixelColor(tempImage, 0, 1, &firstPixel);
for (unsigned int x = 0; x < width; x++) {
if (!emptyImage)
break; break;
// Skip the last line as well.
for (unsigned int y = 1; y < height - 1; y++) {
FreeImage_GetPixelColor(tempImage, x, y, &currPixel);
if (currPixel.rgbBlue != firstPixel.rgbBlue ||
currPixel.rgbGreen != firstPixel.rgbGreen ||
currPixel.rgbRed != firstPixel.rgbRed) {
emptyImage = false;
break;
}
} }
} }
} }
FreeImage_Unload(tempImage); FreeImage_Unload(tempImage);
} }
FreeImage_CloseMemory(memoryStream); FreeImage_CloseMemory(memoryStream);